From 36a27f7a01eb220526f31d5ea9997c48dad85df9 Mon Sep 17 00:00:00 2001
From: xuxueli <931591021@qq.com>
Date: Tue, 30 Sep 2025 23:14:01 +0800
Subject: [PATCH] =?UTF-8?q?refactor(log):=E4=BC=98=E5=8C=96=E6=97=A5?=
 =?UTF-8?q?=E5=BF=97=E8=AF=BB=E5=8F=96=E9=80=BB=E8=BE=91=E5=B9=B6=E4=BF=AE?=
 =?UTF-8?q?=E5=A4=8D=E6=BD=9C=E5=9C=A8=E9=97=AE=E9=A2=98?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- 使用 StringBuilder 替代 StringBuffer 提升性能- 采用 StandardCharsets.UTF_8 确保字符编码一致性
-优化行号判断逻辑，提升代码可读性- 移除冗余注释和无用代码片段-修复日志文件读取时的行数跳过逻辑
- 简化 LogResult 构造逻辑，移除不必要的注释块
---
 .../xxl/job/core/context/XxlJobHelper.java    |  2 +-
 .../xxl/job/core/log/XxlJobFileAppender.java  | 32 +++++++------------
 2 files changed, 12 insertions(+), 22 deletions(-)

diff --git a/xxl-job-core/src/main/java/com/xxl/job/core/context/XxlJobHelper.java b/xxl-job-core/src/main/java/com/xxl/job/core/context/XxlJobHelper.java
index eb20c181..1b025eda 100644
--- a/xxl-job-core/src/main/java/com/xxl/job/core/context/XxlJobHelper.java
+++ b/xxl-job-core/src/main/java/com/xxl/job/core/context/XxlJobHelper.java
@@ -160,7 +160,7 @@ public class XxlJobHelper {
         // appendlog
         String logFileName = xxlJobContext.getJobLogFileName();
 
-        if (logFileName!=null && logFileName.trim().length()>0) {
+        if (logFileName!=null && !logFileName.trim().isEmpty()) {
             XxlJobFileAppender.appendLog(logFileName, formatAppendLog);
             return true;
         } else {
diff --git a/xxl-job-core/src/main/java/com/xxl/job/core/log/XxlJobFileAppender.java b/xxl-job-core/src/main/java/com/xxl/job/core/log/XxlJobFileAppender.java
index 149aa604..9e19d27d 100644
--- a/xxl-job-core/src/main/java/com/xxl/job/core/log/XxlJobFileAppender.java
+++ b/xxl-job-core/src/main/java/com/xxl/job/core/log/XxlJobFileAppender.java
@@ -84,17 +84,16 @@ public class XxlJobFileAppender {
 	/**
 	 * append log
 	 *
-	 * @param logFileName
-	 * @param appendLog
+	 * @param logFileName	log file name
+	 * @param appendLog		append log
 	 */
 	public static void appendLog(String logFileName, String appendLog) {
 
 		// log file
-		if (logFileName==null || logFileName.trim().length()==0) {
+		if (logFileName==null || logFileName.trim().isEmpty()) {
 			return;
 		}
 		File logFile = new File(logFileName);
-
 		if (!logFile.exists()) {
 			try {
 				logFile.createNewFile();
@@ -111,29 +110,20 @@ public class XxlJobFileAppender {
 		appendLog += "\r\n";
 		
 		// append file content
-		FileOutputStream fos = null;
-		try {
-			fos = new FileOutputStream(logFile, true);
-			fos.write(appendLog.getBytes("utf-8"));
-			fos.flush();
-		} catch (Exception e) {
-			logger.error(e.getMessage(), e);
-		} finally {
-			if (fos != null) {
-				try {
-					fos.close();
-				} catch (IOException e) {
-					logger.error(e.getMessage(), e);
-				}
-			}
-		}
+        try (FileOutputStream fos = new FileOutputStream(logFile, true)) {
+            fos.write(appendLog.getBytes(StandardCharsets.UTF_8));
+            fos.flush();
+        } catch (Exception e) {
+            logger.error(e.getMessage(), e);
+        }
 		
 	}
 
 	/**
 	 * support read log-file
 	 *
-	 * @param logFileName
+	 * @param logFileName	log file name
+	 * @param fromLineNum	from line num
 	 * @return log content
 	 */
 	public static LogResult readLog(String logFileName, int fromLineNum){